alexbosworth / lightning

Lightning client methods
MIT License
127 stars 33 forks source link

Typescript definition of subsribeToInvoices does not expect additional parameters #134

Closed woofbotapp closed 1 year ago

woofbotapp commented 1 year ago

https://github.com/alexbosworth/lightning/blob/c5af24b75b88792cb17fa3b5aeb855f901b5f715/typescript/shared.d.ts#L46-L48

In addition to lnd, the function also accepts added_after, confirmed_after, restart_delay_ms.

Would be also nice to document what they mean - I don't understand what the "Index Number" in "Invoice Added After Index Number" is, and why would I need to set a "Restart Subscription Delay".

alexbosworth commented 1 year ago

Invoices have index numbers, you can see that in the invoice event

The subscription has auto restarting in it if it fails, you can mark how much it will wait before trying to start it up again