search

alexbosworth / lightning

Lightning client methods
MIT License
126 stars 32 forks source link

Update types #143

Closed bkiac closed 1 year ago

bkiac commented 1 year ago

@alexbosworth I'm not sure why CI is failing, I haven't changed any JS code and this is the output of the test suite:

# tests 1989
# suites 0
# pass 1989
# fail 0
# cancelled 0
# skipped 0
# todo 0
# duration_ms 307605.365143

seems like all the tests are passing so I don't know why the process exits with code 1, can you take a look?

alexbosworth commented 1 year ago

hmm looks like the test coverage part messes up the CI for some reason

alexbosworth commented 1 year ago

i'll look into how to fix it or if I can't figure it out I'll remove the nyc part

alexbosworth commented 1 year ago

ok i modified the CI, maybe it will work now? Also I changed openChannel to accept UTXOs, it takes an optional array inputs with the attributes transaction_id a hex tx id and transaction_vout a numeric output index

bkiac commented 1 year ago

checks are passing now, and I updated the types of openChannel too