search

alexbosworth / lightning

Lightning client methods
MIT License
126 stars 32 forks source link

Allow env variable for protos directory #175

Closed niteshbalusu11 closed 2 months ago

alexbosworth commented 2 months ago

This method is already exported, why doesn't it just get an argument for the path?

niteshbalusu11 commented 2 months ago

Could do that as well, do you prefer that?

alexbosworth commented 2 months ago

I think it's better as an argument because then there is no problems with naming of the env var

niteshbalusu11 commented 2 months ago

ok, done.