search

alexbosworth / lightning

Lightning client methods
MIT License
127 stars 33 forks source link

Type definitions on `GetPaymentResult` #43

Closed vindard closed 3 years ago

vindard commented 3 years ago

I'm currently working on something that is pulling the type definitions from this library and I noticed there were some properties missing on the GetPaymentResult type that comes back in the method response.

Specifically it looks like these are missing from the "payment" property:

Does this look right, and would you be open to adding these to the type (I don't mind helping here)?

bkiac commented 3 years ago

You are right; they're missing. It seems like the types are included in the docs, but I have missed them somehow. If you could open a PR, that would be great.