search

alexbosworth / ln-service

Node.js interface to LND
MIT License
318 stars 61 forks source link

incoming_peer typo? #133

Closed nicolasburtey closed 3 years ago

nicolasburtey commented 3 years ago

for https://github.com/alexbosworth/ln-service/#payViaPaymentDetails:

[incoming_peer]: <Pay Through Specific Final Hop Public Key Hex String>

shouldn't this be: [incoming_peer__s__]: <Pay Through Specific __Initial__ Hop Public Key Hex String>

?

alexbosworth commented 3 years ago

Initial? This control the final forwarding node, there can only be one with this API

nicolasburtey commented 3 years ago

yeah nevermind this is the outgoing_channels I had in mind.

But there is no equivalent of incoming_peer in https://api.lightning.community/#sendpaymentv2 ?

alexbosworth commented 3 years ago

This value maps to last_hop_pubkey:

https://github.com/alexbosworth/lightning/blob/master/lnd_methods/offchain/subscribe_to_pay.js#L304

nicolasburtey commented 3 years ago

ok, thanks.

another question:

I don't see a way to pass a "[payment]: <Payment Identifier Hex Encoded String>" to payViaPaymentDetails

is there any reason for this? is it something that should be part of messages?

alexbosworth commented 3 years ago

I forget how this works, I think it may be impossible to pass this value on the LND side

nicolasburtey commented 3 years ago

ok. it seems payment is not really mandatory now, I'll investigate this later. thanks.