search

alexbrainman / odbc

odbc driver written in go
BSD 3-Clause "New" or "Revised" License
352 stars 140 forks source link

Minor cleanup #69

Closed judwhite closed 8 years ago

judwhite commented 8 years ago

/cc @ChrisHines

alexbrainman commented 8 years ago

@judwhite did you run the tests? Do they pass? I don't have computer to verify your changes. Thank you.

Alex

judwhite commented 8 years ago

I was able to run the tests with these exceptions:

=== RUN   TestMSSQLReconnect
--- SKIP: TestMSSQLReconnect (0.00s)
        mssql_test.go:1491: Skipping test: no port number provided
=== RUN   TestMSSQLMarkTxBadConn
--- SKIP: TestMSSQLMarkTxBadConn (0.00s)
        mssql_test.go:1558: Skipping test: no port number provided
=== RUN   TestFoxPro
--- SKIP: TestFoxPro (0.00s)
        foxpro_test.go:31: skipping test: SQLDriverConnect: {IM002} [Microsoft][ODBC Driver Manager] Data source name not found and no default driver specified

As a note I had to set the driver to "{SQL Server Native Client 11.0}" instead of just "sql server" in order to have isProto2008OrLater return true. This is probably expected because it's used literally in the ODBC connection string but I wonder if some documentation could help others discover it.

alexbrainman commented 8 years ago

That is fine, lets leave your changes as suggested. Thank you very much for fixing these.

Alex