Closed edharper01 closed 8 years ago
Also, please, squash all commits into one. Otherwise looks good. Thank you very much.
Alex
Hopefully I've made all the changes you asked for; thanks for the very helpful links about how to work with forks.
On 17 August 2016 at 08:35, Alex Brainman notifications@github.com wrote:
Also, please, squash all commits into one. Otherwise looks good. Thank you very much.
Alex
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alexbrainman/odbc/pull/75#issuecomment-240336120, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbRYpOMdgxvNVUR4ewKL-_2Nc9Bu36dks5qgrm4gaJpZM4Jlsd9 .
Please go fmt the code, and I will submit. Thank you.
Alex
The change should be good to go now - I have applied gofmt to param.go Thanks for you patience. Ed
On 18 August 2016 at 01:59, Alex Brainman notifications@github.com wrote:
Please go fmt the code, and I will submit. Thank you.
Alex
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/alexbrainman/odbc/pull/75#issuecomment-240594668, or mute the thread https://github.com/notifications/unsubscribe-auth/AAbRYo-BCmUfmDAx4PcEDv2giBJ5MGrFks5qg65lgaJpZM4Jlsd9 .
I have applied gofmt to param.go
You can just run go fmt
and it will format ALL you code in the current directory. You can also do go fmt .\...
to format everything in the current directory including all sub-directories.
Alex
Unlike freeTDS, the MS ODBC driver (on both Windows and Linux) provides proper support for long data types - varchar/nvarchar/varbinary(max) - where the value is bigger than 8kb.
This change amends the ExtractParameters method to detect these parameters based on the size property.