search

alexbrainman / printer

Windows printing
BSD 3-Clause "New" or "Revised" License
227 stars 80 forks source link

Implement PrinterChangeNotifications #8

Closed jazzy-crane closed 6 years ago

jazzy-crane commented 6 years ago

Still a bit WIP-y

alexbrainman commented 6 years ago

@jazzy-crane I will ignore this PR. Let me know, if I am mistaken.

Alex

jazzy-crane commented 6 years ago

Yes please. Meant to create MR to my own branch master. I expect I will submit something next week but it's still work in progress - not happy with the code structure at the moment. Am keen to discuss next week when I'm back in work - is this functionality something you would be interested in? Is presenting the data as a channel ok or should I just implement the functions raw-ish? (Perhaps both with the former built upon the later in a separate go file?)

On Thu, 4 Oct 2018, 10:30 Alex Brainman, notifications@github.com wrote:

@jazzy-crane https://github.com/jazzy-crane I will ignore this PR. Let me know, if I am mistaken.

Alex

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/alexbrainman/printer/pull/8#issuecomment-426949793, or mute the thread https://github.com/notifications/unsubscribe-auth/AgGQ-soxa8SJiqCEbAafJwCycuUKnxRdks5uhdUtgaJpZM4XG6ki .

alexbrainman commented 6 years ago

is this functionality something you would be interested in?

I am not sure I would be interested. I would like to keep this package as simple as possible.

I don't think many people would want to monitor for print spooler events.

Alex