search

alexbrainman / sspi

Windows SSPI
BSD 3-Clause "New" or "Revised" License
84 stars 27 forks source link

Negotiate improvements #4

Closed vanackere closed 6 years ago

vanackere commented 6 years ago

Hi,

This branch contains various changes / improvements to the negotiate package (FYI those changes were added in order to implement both Web SPNEGO and SASL GSS-SPNEGO support, using the native windows api).

Please merge if you feel those are appropriate, thanks !

vanackere commented 6 years ago

Note: I had to change the prototype from sspi.AcquireCredentials in order to pass the principal name since the C++ code I was porting made use of this parameter. Not breaking the current signature would require a new function (sspi.AcquireCredentialsForPrincipal ?), please let me know if you feel this is a better option.

alexbrainman commented 6 years ago

I will try to review this weekend.

Alex

vanackere commented 6 years ago

Hi, I made the requested changes and updated my branch, PTAL

vanackere commented 6 years ago

Branch updated and rebased, please let me know if I still missed anything, thanks !

alexbrainman commented 6 years ago

LGTM now. Thank you.

Alex

alexbrainman commented 6 years ago

Merged, so closing this now.

Alex