alexbw / novocaine

Painless high-performance audio on iOS and Mac OS X
http://alexbw.github.com/novocaine/
MIT License
2.23k stars 274 forks source link

Setting deployment target to 8.0 causes demo app to crash #126

Open jamesalvarez opened 8 years ago

jamesalvarez commented 8 years ago

I notice the demo has it's deployment target set to 5.1, but I would need to use the library in a minimum 8.0 environment, so I've checked with the demo and aside from the 'AudioSessionGetProperty is deprecated' errors etc, I get an 'Assigning retained object to unsafe property; object will be released after assignment' in AudioFileReader.mm line 221 - and this seems to be the line which causes the demo app to crash. I got around it by setting line 50 to: strong rather than assign - but have not thought about whether this is just a hacky workaround, since when running it again with a 5.1 environment, it doesn't let me do that....

alexbw commented 8 years ago

If it works, it works. I haven't done any work on this project on a few years, so whatever you can do to patch it up is appreciated! Please do open a PR if the solution you found works. On Thu, Sep 1, 2016 at 9:03 AM jamesalvarez notifications@github.com wrote:

I notice the demo has it's deployment target set to 5.1, but I would need to use the library in a minimum 8.0 environment, so I've checked with the demo and aside from the 'AudioSessionGetProperty is deprecated' errors etc, I get an 'Assigning retained object to unsafe property; object will be released after assignment' in AudioFileReader.mm line 221 - and this seems to be the line which causes the demo app to crash. I got around it by setting line 50 to: strong rather than assign - but have not thought about whether this is just a hacky workaround, since when running it again with a 5.1 environment, it doesn't let me do that....

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/alexbw/novocaine/issues/126, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ4jxM341U1DpQIY3dDSBebwcQzE9cyks5qls00gaJpZM4JyqjD .

jamesalvarez commented 8 years ago

It works - but then prevents it working when having the target as 5.1... I will leave it for the time being.