ARC-compatibility and modernization of Obj-c interfaces

[ndonald2]

@alexbw I want to get your eyes on this, I've been using it for my own projects but I want to make sure I didn't miss anything and that this is a direction you're comfortable with.

I tested all the demos on both iOS and OSX and they all seem to work, but you know the project much better than I do, so it's entirely possible that I missed something.

If you'd prefer to keep this in its own branch for awhile that is also fine.

The primary changes are as follows

Code Style and Fixes

• Uses ARC right out of the box
• Removal of all ivars that were backing properties, in favor of auto-synthesized properties (much cleaner, works on XCode 4.4+)
• Moved several properties/methods to class continuation in source file to make them "private"
  • Several things that don't need public access
• Several other properties made readonly in public interface to prevent fiddling (for things that users should never set)
• Block setters/getters explicitly declared so that auto-complete will fill in the arguments for you
• Replaced deprecated AudioProperty getters for OSX (enumerating devices, etc)

  Functional Changes

• Ability to route output to speaker on iPhone (boolean flag)
• Must explicitly call "play" to hear audio
  • I wasn't sure if you'd go for this one or not. It will definitely have an impact but it makes pre-initialization config options possible, since before it would automatically play the first time you access the singleton.

    TODO

• Ability to disable input processing entirely (commented out right now, not implemented yet)
  • Requiring manual call to "play" allows configuring this prior to starting AU
• More advanced audio session/routing capabilities
  • Choosing output routes, etc
  • LOTS of things are available in newer OS versions, for example, audio routing to external devices, etc

Thanks!

[alexbw]

At first glance, this all looks very excellent. I've been traveling this last week, so I hope to be able to get to look at this in more detail early this week. Super excited about all this...

[alexbw]

I'm going to go ahead and merge it in. It's in production for you, and fixes a variety of problems that were outstanding. Very awesome.

I'm also in favor of requiring [audioManager play] and will update the front-page example accordingly. I'll try to get to the internal examples later.

[alexbw]

So, should be

Novocaine *audioManager = [Novocaine audioManager];
[audioManager play];

right? Does this fix the outstanding return-from-background bug? Don't have to know the answer, just curious if it was apparent off the top of your head.

[ndonald2]

That is correct code - the idea is to be able to configure options prior to starting the AU.

I'm not sure I know of the return-from-background bug. If you point me in the right direction I can probably take a look at it sometime soon, though.

[ndonald2]

I also noticed a few loose ends and just went ahead and fixed them in master

• Build error for mac demo
• Cleaned up extraneous comments in headers
• Update README to call [audioManager play] after setting up block

[alexbw]

It's in the other open pull request https://github.com/alexbw/novocaine/pull/45

[jonasman]

any news on this library?

It crashes my app just by including it. I disabled the mm files and still crashes. I would like to try the pull requests if they are good to go.

[alexbw]

Can you fork this project, and try merging PR 49 and 45, testing it, and letting me know if it works for you?