search

alexcasalboni / aws-lambda-power-tuning

AWS Lambda Power Tuning is an open-source tool that can help you visualize and fine-tune the memory/power configuration of Lambda functions. It runs in your own AWS account - powered by AWS Step Functions - and it supports three optimization strategies: cost, speed, and balanced.
Apache License 2.0
5.41k stars 373 forks source link

Add opportunity to provide a permission boundary #163

Closed ldcorentin closed 2 years ago

ldcorentin commented 2 years ago

Hello,

In order to use it, I need to provide a permission boundary to the role that are going to be created.

I also did some cleaning like the region is never used inside the module.

Thanks!

alexcasalboni commented 2 years ago

Thank you for contributing, @ldcorentin 🙏

This functionality is already supported in the SAM/CloudFormation version, indeed.

+ @andybkay for visiblity :)

ldcorentin commented 2 years ago

Hey @andybkay. Any chance you had time to have a look ? :)

andy-kay-and commented 2 years ago

Approved on this change, looks like a valuable addition.

alexcasalboni commented 2 years ago

Thank you @andy-kay-and for reviewing 🙏

And @ldcorentin for contributing 🙏

I'm merging this now 🚀

alexcasalboni commented 2 years ago

FYI I've also removed the reference to variable "aws_region" from the Terraform doc: https://github.com/alexcasalboni/aws-lambda-power-tuning/commit/f3f49987ab96647f2585182916a94fa32c414a2b