search

alexcasalboni / aws-lambda-power-tuning

AWS Lambda Power Tuning is an open-source tool that can help you visualize and fine-tune the memory/power configuration of Lambda functions. It runs in your own AWS account - powered by AWS Step Functions - and it supports three optimization strategies: cost, speed, and balanced.
Apache License 2.0
5.29k stars 363 forks source link

Optional trimmed mean #172

Closed Parro closed 1 year ago

Parro commented 1 year ago

For the validation that check that the param is between 0 and 0.4 I used the same style of getBalancedWeight in analyzer.js. For the doc, I copied from the issue, I think it's quite explicative :wink:

alexcasalboni commented 1 year ago

Thanks for contributing 🎉🙏

I’ll review and merge in the next 2-3 weeks (I’m currently on vacation).

In the meantime, it would be fantastic if you could add a couple more tests to play with different percentages and edge cases.

On Wed, 20 Jul 2022 at 11:03, Mauro Parolari @.***> wrote:

For the validation that check that the param is between 0 and 0.4 I used the same style of getBalancedWeight in analyzer.js. For the doc, I copied from the issue, I think it's quite explicative 😉

You can view, comment on, or merge this pull request online at:

https://github.com/alexcasalboni/aws-lambda-power-tuning/pull/172 Commit Summary

File Changes

(7 files https://github.com/alexcasalboni/aws-lambda-power-tuning/pull/172/files)

Patch Links:

- https://github.com/alexcasalboni/aws-lambda-power-tuning/pull/172.patch

https://github.com/alexcasalboni/aws-lambda-power-tuning/pull/172.diff

— Reply to this email directly, view it on GitHub https://github.com/alexcasalboni/aws-lambda-power-tuning/pull/172, or unsubscribe https://github.com/notifications/unsubscribe-auth/AASX75DGXOI7ZYOJLF5HMR3VU7FFXANCNFSM54DAVTMA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Parro commented 1 year ago

Thanks for contributing 🎉🙏 I’ll review and merge in the next 2-3 weeks (I’m currently on vacation). In the meantime, it would be fantastic if you could add a couple more tests to play with different percentages and edge cases.

I added some tests and brought back the coverage to 100%

alexcasalboni commented 1 year ago

Hey @Parro I've applied a few very minor changes to improve tests & documentation.

Thank you again for contributing 🙏 I'm merging this now!