search

alexcesaro / statsdbench

A benchmark of Go StatsD clients.
2 stars 7 forks source link

timingValue - int vs. time.Duration #3

Open peter-mogensen opened 8 years ago

peter-mogensen commented 8 years ago

It seems to me the current code gives a misleading benchmark, since the Timing() method of the alexcesaro client takes in interface{} as its value - which is passed all the way down to appendNumber(), but since it's not a numeric it's not appended at all.

So calls to func (c *Client) Timing(bucket string, value interface{}) should take something which appendNumber can recognizes. But not a time.Duration.

dropwhile commented 5 years ago

Also pretty out of date (4 years old). https://github.com/cactus/go-statsd-client has gotten much faster over the years

joeycumines commented 2 years ago

(I'm aware that these comments are from many years ago)

I've updated these benchmarks.