Add UI controls for vibrate and tone dialing feedback

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Dial a number (digit dialer)
2. Feel vibration but no tones
3. Look in prefs, see no way to control this

What is the expected output? What do you see instead?

Expected: Prefs for dial tone and vibrate feedback
Saw: No way to control either

Please use labels and text to provide additional information.

Original issue reported on code.google.com by dc3de...@gmail.com on 30 Jul 2010 at 10:40

[GoogleCodeExporter]

Added to "General user interface" preferences. Tested to make sure changes to 
these prefs are picked up without having to exit and restart the app. Also 
altered the logic for when to vibrate so that it does not vibrate when the 
phone is on silent.

See r172

Original comment by dc3de...@gmail.com on 30 Jul 2010 at 10:46

• Changed state: Fixed
• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Please set dial_press_tone by default to false.
Dialtone generator is buggy on some devices (or at least it was not well 
implement it - probably a leak but deadlock in audio layer was present on X10 
and samsung i7500).
That's the reason why i disabled it in the code (and postponed the 
implementation of dialtone generation in the dialer).

Original comment by r3gis...@gmail.com on 31 Jul 2010 at 4:44

• Changed state: Accepted

[GoogleCodeExporter]

Done, r173

Original comment by dc3de...@gmail.com on 31 Jul 2010 at 5:20

• Changed state: Fixed

[GoogleCodeExporter]

Thx,
I'll try to debug the deadlock issue on the device of a collegue. Then, we 
probably will reactivate it by default once fixed, but for now, it's better to 
avoid the issue by default.

Original comment by r3gis...@gmail.com on 31 Jul 2010 at 7:59