alexchengalan / csipsimple

Automatically exported from code.google.com/p/csipsimple
0 stars 0 forks source link

Dialpad 0/+ button needs to enter '+' on long press #133

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open the app
2. Long press on 0/+ button to enter '+'

What is the expected output? What do you see instead?

Expected: '+' to be entered
Saw: Nothing happens

Please use labels and text to provide additional information.

My SIP server has rules for dialing with standard format numbers like

  +1 nnn nnn nnnn   (turned into 1nnnnnnnnnn for domestic)
  +nn nn ...        (turned into 011nnnn.... for international)

and I have the numbers in that format on my phone (thanks to the Contacts 
Cleaner app!!). That means I can dial right from my phone and the switch will 
route accordingly. FOr manually entered numbers, I need to have the '+' to 
trigger that rule (yeah, I could just dial 1 or 011 but ...).

Original issue reported on code.google.com by dc3de...@gmail.com on 6 Aug 2010 at 9:35

GoogleCodeExporter commented 9 years ago
Fixed, see r181

Original comment by dc3de...@gmail.com on 6 Aug 2010 at 9:38

GoogleCodeExporter commented 9 years ago
Drat! Forgot optional haptic feedback on the now-rewired 0/+ button. 

Original comment by dc3de...@gmail.com on 7 Aug 2010 at 12:07

GoogleCodeExporter commented 9 years ago
Fixed (again), see r185. Also lengthened the haptic feedback duration from 30 
to 50 ms for more positive feel. Made the duration a manifest constant in 
Dialer.java.

Original comment by dc3de...@gmail.com on 7 Aug 2010 at 12:23