search

alexchengalan / csipsimple

Automatically exported from code.google.com/p/csipsimple
0 stars 0 forks source link

Cannot hangup ongoing call #149

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Sometimes (very rarely) it seems the application gets into a state where it is 
impossible to hangup a call in progress in CSipSimple. Nothing happens as a 
result of pressing the button. I have experienced this a few times 
unfortunately logging hass been off at the time.

The InCallActivity onTrigger method also seems to only end a call once so if 
for some reason the first attempt fails (which it should not...) then all 
subsequent button presses to end the ongoing call will be ignored.

Original issue reported on code.google.com by michael....@gmail.com on 20 Aug 2010 at 10:55

GoogleCodeExporter commented 9 years ago 
Yes you're right. I did it because sometimes it was called twice within the 
same second (particularly using the take /decline call slider on old devices) 
and it was resulting the native layer to crash since the call was not present 
any more when the second invoke is done.
But that's not clean at all. I will change things into a mutex in the service 
and a extra check that test if call is still present when a second invokation 
is done (unless you want to do it?).

Original comment by r3gis...@gmail.com on 20 Aug 2010 at 11:04

GoogleCodeExporter commented 9 years ago 
Changes done in trunk. (I'll try to push a -12-23 on the download section in a 
couple of hour)
Cleaner implementation now : just added a mutex in the service. UI doesn't take 
care anymore about what to do with a call, pjsip does the work for us provided 
the fact there is a mutex on the top of answer/hangup methods.

Original comment by r3gis...@gmail.com on 26 Aug 2010 at 6:08

GoogleCodeExporter commented 9 years ago

Original comment by r3gis...@gmail.com on 26 Aug 2010 at 6:08

GoogleCodeExporter commented 9 years ago

Original comment by r3gis...@gmail.com on 25 Sep 2010 at 2:39