search

alexcode / vue2vis

A Vuejs 2 adapter for Visjs
MIT License
217 stars 59 forks source link

visjs and visjs-community #45

Open pleek91 opened 5 years ago

pleek91 commented 5 years ago

The main visjs has been end of life'd in favor of individual repositories for the individual features.

Here's the post about it. https://github.com/almende/vis/issues/4259

Looks like the network and timeline have been broken out into their own modules. https://github.com/visjs-community

Considering the main visjs repository is no longer being updated. It would be great to update vue2vis to use these new modules as they become available. I'd be willing to work on the timeline component. But I'd like to know if @alexcode is open to moving forward with this before I start working on it.

Thanks

alexcode commented 5 years ago

Thanks for the heads-up @pleek91. I haven't spend time on this project recently but I will still invest although mainly on the timeline as well. I agree with you that if we want to benefit from the vis.js development going forward, we need to use the new modules.

This raise the question of having only one repo/npm module. Should we breakdown this repo as well or importing all the vis-community into this one ?

On a side note, I'm not sure the community modules are ready yet.

@Menighin what do you think ?

Thanks Alex

pleek91 commented 5 years ago

@alexcode I like the idea of having multiple repos following the direction that the vis-community repo is going. Also, the timeline-plus module has been actively developed for a while. That one might be ready to use. Not sure about the others.

Menighin commented 5 years ago

Hi guys,

I agree on splitting vue2vis into modules, following Vis direction. I have been busy lately as well but will help on the Network asap (dunno if the Vis module for network is ready as well).

alexcode commented 5 years ago

@Menighin the network seems to be at https://github.com/visjs-community/visjs-network

micahstubbs commented 5 years ago

hello 👋 visjs-network maintainer here.

I'm happy to help update to vue2vis to use visjs-network for network visualization if that is something that interests you all.

the API of https://www.npmjs.com/package/visjs-network is backwards compatible with the legacy https://www.npmjs.com/package/vis mono-library.

we follow semver in visjs-network, so that backwards compatibility will be maintained at least until the next major version of visjs-network

pleek91 commented 5 years ago

@yotamberk is this something you would be willing to help with?

yotamberk commented 5 years ago

I will be moving to vis-community in the next few weeks. Until then you are welcome to use my fork: https://github.com/yotamberk/timeline-plus

pleek91 commented 5 years ago

Looks like timeline-plus has been moved into vis-community.

yotamberk commented 5 years ago

Not an updated version. Still working on my own fork. I will move there eventually

r3code commented 5 years ago

@Menighin @alexcode @pleek91 @yotamberk @micahstubbs This week I created vue-vis-network based on the vue2vis. It contains only https://github.com/visjs/vis-network. Should I publish it at NPM?

havardthom commented 5 years ago

Hi, is anyone working on a vue wrapper for the vis-community timeline repo? https://github.com/visjs/vis-timeline

alexcode commented 5 years ago

Well, I'm not sure if we should go the multi-repo way as visJs does. It make sense from their perspective but as wrapper I feel that we maybe better of the monorepo way with Lerna. As we reuse the same boilerplate and utils, the bug fixes/features/upgrade would benefit the whole wrapper but still be split in lightweight NPM packages with a monorepo. What do you think ?

r3code commented 5 years ago

If you think so. You should organize a base repo structure. Meantime I thank you for your work - it give me the base for rapid adaptation of new visjs to vue.

Well, I'm not sure if we should go the multi-repo way as visJs does. It make sense from their perspective but as wrapper I feel that we maybe better of the monorepo way with Lerna. As we reuse the same boilerplate and utils, the bug fixes/features/upgrade would benefit the whole wrapper but still be split in lightweight NPM packages with a monorepo. What do you think ?

micahstubbs commented 5 years ago

@r3code thanks for asking, I would say that's a decision for you and your user community 😄

For upstream library authoring, splitting into multiple repos is nice, because it lets maintainers focus on the part of the library that they really care about. If you and your fellow maintainers care about all of the parts of vue2vis, then I think the monorepo approach with Lerna that @alexcode suggests sounds reasonable.

meshy commented 4 years ago

@r3code thanks for making the fork. If you published your fork to NPM, I'm sure I wouldn't be the only one to use and appreciate it.

r3code commented 4 years ago

@meshy Ok. I'll publish as soon as possible. You are not the first who asked me to publish, so I think I should do it.

meshy commented 4 years ago

@r3code thank you -- don't hurry just for me though -- I'm happy for you to take your time :)

r3code commented 4 years ago

@meshy I'll publish in 48 hours. I Had published once but forgot to generate dist which I need to create jsfiddle demo

meshy commented 4 years ago

Honestly, there's no rush -- I think I've found a good enough work-around for my use-case now anyway. Still -- others might find it useful!

r3code commented 4 years ago

@meshy Published https://www.npmjs.com/package/vue-vis-network/v/1.0.1