search

alexcouper / captainhook

Git hook scripts
BSD 3-Clause "New" or "Revised" License
54 stars 14 forks source link

Replace python3 compile action with 2to3 action #43

Closed koddsson closed 10 years ago

koddsson commented 10 years ago

This PR makes the python3 checker run a 2to3 code analysis on python code about to be committed instead of compiling it as python3. The advantage being that you get a diff view of all the changes you should make before committing rather than the first compile error that the python3 interpreter hit.

alexcouper commented 10 years ago

Looking forward to checking this out!

alexcouper commented 10 years ago

On my mac I had to use 2to3-2.7 to get this to work.

Is that something that also exists on ubuntu?

koddsson commented 10 years ago

Yup! Works the same for me.

Kristján Oddsson.

On Mon, Jun 2, 2014 at 11:43 PM, Alex Couper notifications@github.com wrote:

On my mac I had to use 2to3-2.7 to get this to work.

Is that something that also exists on ubuntu?

— Reply to this email directly or view it on GitHub https://github.com/alexcouper/captainhook/pull/43#issuecomment-44904554.

alexcouper commented 10 years ago

Nice - merging in that case. I'll make changes and add a behave test post-merge.