search

alexcouper / captainhook

Git hook scripts
BSD 3-Clause "New" or "Revised" License
54 stars 14 forks source link

Pytest checkers #90

Closed Friz-zy closed 8 years ago

Friz-zy commented 8 years ago

Optional checkers:

alexcouper commented 8 years ago

Thanks for the PRs - I'll do a review of them both now...

Seems to be a test failing on travis here.

May well be distribution related. I'm running on a mac and they pass - might be you get different output back from git on a linux distribution. Not sure.

Friz-zy commented 8 years ago

Yep, thanks for feedback, i've been waiting for it. About dependencies: i planned this modules as optional so i didn't add pylint and pytest to requirements, but i can do it if you think that it's necessary. About refactoring and tests: i don't like repeat myself, so i'll refactor it. But it may take a time...

alexcouper commented 8 years ago

Yeah i like it being optional - and it won't be installed when people pip install, it's just for us to be able to run any sort of behave-like test we'll need it in test-requirements.

Nice work though :)

alexcouper commented 8 years ago

I'll wait for this to get rebased, green and merged before releasing a new captainhook version.

Friz-zy commented 8 years ago

Thanks, I'm trying to figure out what is wrong and how reproduce it

Friz-zy commented 8 years ago

Merge it please before next conflict with master =)

alexcouper commented 8 years ago

@Friz-zy ah hadn't seen that you had resolved this.

I'll take a look at it tomorrow.

alexcouper commented 8 years ago

Nice one @Friz-zy :) I'll release a new version shortly...

alexcouper commented 8 years ago

Released 0.8.6.