Closed Friz-zy closed 8 years ago
Thanks for the PRs - I'll do a review of them both now...
Seems to be a test failing on travis here.
May well be distribution related. I'm running on a mac and they pass - might be you get different output back from git on a linux distribution. Not sure.
Yep, thanks for feedback, i've been waiting for it. About dependencies: i planned this modules as optional so i didn't add pylint and pytest to requirements, but i can do it if you think that it's necessary. About refactoring and tests: i don't like repeat myself, so i'll refactor it. But it may take a time...
Yeah i like it being optional - and it won't be installed when people pip install, it's just for us to be able to run any sort of behave-like test we'll need it in test-requirements.
Nice work though :)
I'll wait for this to get rebased, green and merged before releasing a new captainhook version.
Thanks, I'm trying to figure out what is wrong and how reproduce it
Merge it please before next conflict with master =)
@Friz-zy ah hadn't seen that you had resolved this.
I'll take a look at it tomorrow.
Nice one @Friz-zy :) I'll release a new version shortly...
Released 0.8.6.
Optional checkers:
py.test -q
pytest -q --cov