alexcouper / captainhook

Git hook scripts
BSD 3-Clause "New" or "Revised" License
54 stars 14 forks source link

Pylint checkers #91

Closed Friz-zy closed 8 years ago

Friz-zy commented 8 years ago

Optional checkers:

alexcouper commented 8 years ago

We'll need to add pylint as a test dependency for these to get past travis

Friz-zy commented 8 years ago

Strange

Then I see no errors                                                           # features/steps/output_steps.py:10 0.000s

      Assertion Failed: '' != '===============================================================================

      Checking pylint

      ===============================================================================

      pylint is required for the pylint plugin.

      `pip install pylint` or turn it off in your tox.ini file.

      ===============================================================================

      Rejecting commit

      ===============================================================================

      '

    And there are no uncommitted changes  

But i added pylint into requirements...

alexcouper commented 8 years ago

Add them to test-requirements instead.

If you look at the top of the travis build the set up is:

$ pip install -r test-requirements.txt
$ pip install -e .
$ nosetests

And since we only want them for testing, adding them there makes sense (the other alternative would be to add them to the dependencies in setup.py, but as you say, we want this to be optional).

Friz-zy commented 8 years ago

ups, my bad fixed =)

alexcouper commented 8 years ago

Thanks - nice work.