alexcrack / angular-ui-notification

Angular.js service providing simple notifications using Bootstrap 3 styles with css transitions for animating
MIT License
536 stars 169 forks source link

Adding a custom property to scope is not documented #129

Open 1TheMuffinMan opened 7 years ago

1TheMuffinMan commented 7 years ago

At the bottom of the documentation it says that you can add your own scope properties in addition to message and title, however there's a lot of documentation missing on that functionality.

There is no documentation that specifies that you must create your own scope, add your custom property to it and then set the undocumented scope property in the notification:

var scope = $rootScope.$new(false);
scope.event = notificationEvent;
//show toast
Notification({
    title: notificationEvent.displayText,
    scope: scope,
    templateUrl: '/client/app/core/ui/directives/events/signalrEventItem.html'
});

Would you accept a pull request for this?

SuigetsuSake commented 7 years ago

+1 For this, I needed this and couldn't know from the current docs

Thanks :)