search

alexcrack / angular-ui-notification

Angular.js service providing simple notifications using Bootstrap 3 styles with css transitions for animating
MIT License
536 stars 169 forks source link

Change name of provider #131

Open lesimoes opened 7 years ago

lesimoes commented 7 years ago

This provider has name 'Notification' same name of Web API Notification implements on all browsers. You can use angularjs safe dependency injection to avoid this problem, but i believe this is bad practice that can generate conflicts.

In my project i override for 'angularNotification' and use safe dependency injection to tackle this problem

bencun commented 6 years ago

+1 I agree on this suggestion for the very same reason as the OP.