alexcrack / angular-ui-notification

Angular.js service providing simple notifications using Bootstrap 3 styles with css transitions for animating
MIT License
536 stars 169 forks source link

Top plus height position calculation seems wrong #143

Open shirashif opened 6 years ago

shirashif commented 6 years ago

When I have multiple notifications, that exceed the visible window height, the last one that appears in the column, before moving to the next column is partly cut. This is the original code:

if ((top + elHeight) > window.innerHeight) {
    position = startTop;
    k ++;
    j = 0;
}

To fix I changed the query to this: if ((position + elHeight) > window.innerHeight) {