Destroy associated scope when template element is removed

alexcrack / angular-ui-notification

Angular.js service providing simple notifications using Bootstrap 3 styles with css transitions for animating

MIT License

536 stars 169 forks source link

Closed vtertre closed 8 years ago

vtertre commented 9 years ago

I might be missing something but it seems that the scope created for each notification (var scope = args.scope.$new();) is never destroyed.

Is there a way to properly cleanup the scope when the template element is removed ?

alexcrack commented 9 years ago

Just tested it. Yes you are right. Many of created scopes will influence on perfomance. It will be fixed in future. Thank you.

cklemming commented 8 years ago

Any update on this? Thanks for a great library otherwise.

dgreene1 commented 8 years ago

Glad someone caught that. Any idea when the fix/enhancement will be available?

alexcrack commented 8 years ago

Fixed in 2e17ab143dd9e1dc02aa6a2ec9532e97c62f6e47

New release coming soon