search

alexcrack / angular-ui-notification

Angular.js service providing simple notifications using Bootstrap 3 styles with css transitions for animating
MIT License
536 stars 169 forks source link

'Killed' elements remain in the DOM #55

Closed mikedaly closed 8 years ago

mikedaly commented 8 years ago

I notice that when notifications fade out, they do that via the 'killed' class which sets their opacity to 0. But I don't see anything in the code which removes those elements from the DOM. I think invisible notifications will accumulate indefinitely, bloating the DOM. Seems like there should be a periodic mechanism to cull out these old elements, removing the from the DOM entirely.

mikedaly commented 8 years ago

Nevermind. I see now where the element is removed.