search

alexcrichton / cargo-vendor

Archived as subcommand is now part of Cargo itself
Apache License 2.0
261 stars 30 forks source link

README.md: add NSS SSL hint for curl failure #256

Closed TorstenScheck closed 5 years ago

TorstenScheck commented 5 years ago

I was bitten by this issue, so I'd better document it.

Alternatively, the curl build could be adapted to not consider libcurl-nss.

alexcrichton commented 5 years ago

Thanks for this! I wonder though if the README is perhaps too prominent of a location to mention this? Would this perhaps be better for the curl documentation?

TorstenScheck commented 5 years ago

Thank you for considering the issue.

I don't think that users will have problems with curl, as they usually install it as a binary package. It affects cargo-vendor, as curl is built in the cargo-install process.

As mentioned in the PR, the curl build in cargo-vendor could be adapted to not consider libcurl-nss. Then there was no need for the documentation.

Or cargo-vendor could print a hint about the missing library, when curl error number 77 occurs.

Or the proposed documentation change could be moved into an FAQ or Troubleshooting section/file.

Or it might be even sufficient, if this pull request stayed open, so people will find the solution when searching the web. ;-)

alexcrichton commented 5 years ago

Yeah I agree an FAQ/Troubleshooting section would be great, although we don't really have one currently... FWIW I mostly meant https://github.com/alexcrichton/curl-rust rather than curl itself

TorstenScheck commented 5 years ago

Moving hint to curl-rust as recommended.