alexcrichton / curl-rust

Rust bindings to libcurl
MIT License
1.02k stars 235 forks source link

Add unix_socket_path that exposes more Unix socket control #347

Closed sagebind closed 4 years ago

sagebind commented 4 years ago

The existing unix_socket method has some limitations in its design:

This adds a second method named unix_socket_path that instead takes an Option<impl AsRef<Path>> which more closely aligns with what libcurl accepts for this option. We could consider soft-deprecating unix_socket, but I left it alone for now.

alexcrichton commented 4 years ago

Seems reasonable to me!