search

alexcrichton / curl-rust

Rust bindings to libcurl
MIT License
1.01k stars 234 forks source link

Add support for aws-sigv4 authentication #401

Closed theawless closed 2 years ago

theawless commented 2 years ago

Used these platforms:

I wasn't sure what feature combinations to build curl-rust with to test properly. So, I wrote this script which runs all of them (1024 combinations). Would it be useful to add it in the CI somehow?

For macOS and Linux, all builds work fine. For Windows, some of them are breaking, but they had been breaking before my changes. mesalink + spnego doesn't build together on Windows. Is this expected?

Closes https://github.com/alexcrichton/curl-rust/issues/392

alexcrichton commented 2 years ago

Seems reasonable to me, thanks!

I think it's ok to keep CI as is (building all the sets of features isn't always the most useful and can take a lot of time), and for file order in the build script it's pretty haphazard and not super principled, so wherever is fine.