search

alexcrichton / curl-rust

Rust bindings to libcurl
MIT License
1k stars 234 forks source link

Update OpenSSL dependencies #454

Closed silverjam closed 1 year ago

silverjam commented 1 year ago

Allows build to succeed on Ubuntu 22.04 -- current OpenSSL deps fail with this error (which appears fixed upstream):

  CARGO_CFG_TARGET_FEATURE = Some("fxsr,sse,sse2")
  running: "gcc" "-O0" "-ffunction-sections" "-fdata-sections" "-fPIC" "-g" "-fno-omit-frame-pointer" "-m64" "-I" "/usr/include" "-Wall" "-Wextra" "-E" "build/expando.c"
  cargo:warning=build/expando.c:4:24: error: pasting "RUST_VERSION_OPENSSL_" and "(" does not give a valid preprocessing token         cargo:warning=    4 | #define VERSION2(n, v) RUST_VERSION_##n##_##v                                                                  cargo:warning=      |                        ^~~~~~~~~~~~~                                                                           cargo:warning=build/expando.c:5:23: note: in expansion of macro ‘VERSION2’                                                           cargo:warning=    5 | #define VERSION(n, v) VERSION2(n, v)
  cargo:warning=      |                       ^~~~~~~~
  cargo:warning=build/expando.c:10:1: note: in expansion of macro ‘VERSION’                                                            cargo:warning=   10 | VERSION(OPENSSL, OPENSSL_VERSION_NUMBER)
  cargo:warning=      | ^~~~~~~                                                                                                        exit status: 1
alexcrichton commented 1 year ago

Thanks for the PR but this isn't necessary, these are semver-compatible updates which means you just need to update your local project/lock file if necessary.