Add the ability to use pkg_config on windows build

alexcrichton / curl-rust

Rust bindings to libcurl

MIT License

1k stars 234 forks source link

Add the ability to use pkg_config on windows build #486

Open lepapareil opened 1 year ago

lepapareil commented 1 year ago

Closes #484

lepapareil commented 1 year ago

Hi @alexcrichton and @sagebind can you review this change please ? Many Thks 😀.

alexcrichton commented 1 year ago

Sorry this is one I don't personally have the time to invest in at this time. Changing build behavior of longstanding platforms often comes with breakage perhaps months down the line that I'm not in a position to manage at this time personally.

lepapareil commented 1 year ago

I understand.

micolous commented 11 months ago

It looks like pkg-config-rs with MSVC had actually been fixed up: https://github.com/rust-lang/pkg-config-rs/pull/72, so it can be used on MSVC just fine (eg: https://github.com/rust-lang/libz-sys/pull/39).