alexcrichton / curl-rust

Rust bindings to libcurl
MIT License
1k stars 234 forks source link

Allow using vcpkg on any Windows target, and use find_package #509

Open micolous opened 1 year ago

micolous commented 1 year ago

This change addresses two issues building for Windows:

While here, I've disabled fail_fast in the CI configuration, as a single-platform flake cancels tests on slower platforms (eg: MSVC).

micolous commented 11 months ago

@alexcrichton Any feedback on this? This is currently the last PR blocking https://github.com/mcgoo/vcpkg-rs/pull/52, because curl-rust is in its CI configuration.

alexcrichton commented 11 months ago

Sorry for the delay, but I'm not confident myself signing off on this just yet. I would need to investigate the relevant packages and pieces involved here to ensure that everything works as I'd expect and I don't see any issues with this integration. I don't have the time to do this right now, though. @sagebind do you have thoughts on this though?