SomeoneToIgnore
commented
9 months ago I am trying to fix the initialization crash with this patch, but when I apply patch on top of https://github.com/sagebind/isahc and run cargo test, I get the same error as in the issue above:
diff --git a/Cargo.toml b/Cargo.toml
index d797d20..af49991 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -50,12 +50,14 @@ waker-fn = "1" # async primitive
# underlying HTTP engine that powers Isahc
[dependencies.curl]
-version = "0.4.43"
+git = "https://github.com/SomeoneToIgnore/curl-rust"
+branch = "update-curl"
default-features = false
# access to certain curl APIs not exposed in safe wrapper
[dependencies.curl-sys]
-version = "0.4.55"
+git = "https://github.com/SomeoneToIgnore/curl-rust"
+branch = "update-curl"
default-features = false
# used in TLS cert parsing
diff --git a/benchmarks/Cargo.toml b/benchmarks/Cargo.toml
index ddbf688..d3c12d4 100644
--- a/benchmarks/Cargo.toml
+++ b/benchmarks/Cargo.toml
@@ -6,11 +6,14 @@ publish = false
[dependencies]
criterion = "0.4"
-curl = "0.4.42"
rayon = "1"
rouille = "3"
reqwest = { version = "0.11.10", features = ["blocking"] }
+[dependencies.curl]
+git = "https://github.com/SomeoneToIgnore/curl-rust"
+branch = "update-curl"
+
[dependencies.isahc]
path = ".."Yet, it appears in curl changelog for curl and libcurl 8.4.0
cmake, configure: also link with CoreServices [32]
is present that includes https://github.com/curl/curl/commit/6ab7e1990bd548059f08c471d20537bca13c67b6
What am I doing wrong and how could I fix curl init for Sonoma?
ehuss
speelbarrow
Closes https://github.com/alexcrichton/curl-rust/issues/524
Fix macOs Sonoma curl initialization crash: https://github.com/curl/curl/issues/11893 by linking with
CoreServicesas the corresponding curl fix did: https://github.com/curl/curl/commit/6ab7e1990bd548059f08c471d20537bca13c67b6