alexcrichton / curl-rust

Rust bindings to libcurl
MIT License
1.02k stars 234 forks source link

error: unsupported output in build script of `curl-sys v0.4.76+curl-8.10.1`: `cargo::rustc-check-cfg=cfg(libcurl_vendored,link_libnghttp2,link_libz,link_openssl,)` #576

Closed glandium closed 1 week ago

glandium commented 3 weeks ago

575 accidentally increased the (undocumented) MSRV to 1.80, and older rust versions fail to compile.

iamalwaysuncomfortable commented 2 weeks ago

I'm Also experiencing this issue

nabijaczleweli commented 2 weeks ago

Just got this report downstream: https://github.com/nabijaczleweli/cargo-update/issues/277

This user is on the current Ubuntu LTS, which ships 1.75. Naturally, I would like to avoid fielding more reports like this.

There's no reason to not spell this as cargo:rustc-check-cfg (just as there was no reason to devise the cargo:: syntax in the first place, especially without a failover period).

alexcrichton commented 1 week ago

Naturally, I would like to avoid fielding more reports like this.

Personally I find this tone abrasive and unnecessarily conflict-oriented. No one's trying to foist work onto you and force you to deal with things. Bugs like this happen, and it's a part of how OSS works. I'd encourage you to pause before making comments like this since it ends up not really helping anyone for you to vent frustration to strangers on the internet.

nabijaczleweli commented 1 week ago

Sorry, that's not what I meant by this. This was an ill-thought short-hand for "I expect to see more of these [from Ubuntu LTS users], so I hope to fix this myself in short order, and would like to hope for this to be releasable on its own [such that I can avoid fielding more reports like this].". my b if that read too short. happens, of course, and I'm happy to chase this up the dependency tree

alexcrichton commented 1 week ago

Thanks for clarifying! Also a good reminder for me to assume good faith on everyone's behalf. This is a case of only-text communication not being easy, and I know I mess it up all the time as well. Regardless thanks for helping to fix!