search

alexcrichton / openssl-probe

Apache License 2.0
54 stars 13 forks source link

Breaking change in 0.1.3, type signature of openssl_probe::init_ssl_cert_env_vars() now returns bool #16

Closed kellpossible closed 3 years ago

kellpossible commented 4 years ago

Sorry @alexcrichton , found another breaking change :sweat_smile: 

error[E0308]: mismatched types
  --> ~/.cargo/registry/src/github.com-1ecc6299db9ec823/native-tls-0.2.4/src/imp/openssl.rs:94:23
   |
94 |     ONCE.call_once(|| openssl_probe::init_ssl_cert_env_vars());
   |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ expected `()`, found `bool`

error: aborting due to previous error
alexcrichton commented 4 years ago

Ok, I've yanked this version. Sorry I don't have time to manage this.

JeffVeit commented 4 years ago

Confirmed; I just had this error too.

frol commented 4 years ago

Can we have 0.2.0 release, please? :pray:

frol commented 4 years ago

I had submitted a PR to rust-native-tls: https://github.com/sfackler/rust-native-tls/pull/182

If this package will get 0.2 release, we can update Cargo.toml in rust-native-tls to support openssl-probe >=0.1,<=0.2

alexcrichton commented 4 years ago

Sorry I don't really have time to manage this crate very well. I think w/e the original breaking change was needs to be backed out to publish a new version of this crate.

frol commented 4 years ago

@alexcrichton I volunteer myself to be a temporary maintainer for this package to release both versions: a proper 0.1.x without the breaking change and 0.2.x with the breaking change. (I have a relevant experience maintaining various projects in Rust, Python, and Linux repositories.)

alexcrichton commented 4 years ago

I don't think a new breaking change is necessary for this crate. I think what should be done is to provide the breaking change as a new function and otherwise keep existing interfaces the same. If someone can help out doing that I should be able to publish.