search

alexcrichton / openssl-src-rs

Source code and logic to build OpenSSL from source
Apache License 2.0
69 stars 115 forks source link

Pass no-stdio to OpenSSL's configure #14

Closed alexcrichton closed 6 years ago

alexcrichton commented 6 years ago

Apparently it doesn't link on Android otherwise and we don't use any of the functionality anyway!

Closes #13

sfackler commented 6 years ago

openssl-sys will need to look for this feature flag since I think it binds to a couple of APIs that involve FILE * but that should be fine.

alexcrichton commented 6 years ago

ping @sfackler, any objections to merging?

sfackler commented 6 years ago

Do you know why the linker failure wouldn't show up in the CI? It targets android right?

Might be worth rebasing this over the 1.1.1 bump and seeing if that fixes the windows build.

alexcrichton commented 6 years ago

We test that android targets build yeah but we don't do a great job of testing it all links currently, we only pull in the OpenSSL_version_num symbol and test that links right

alexcrichton commented 6 years ago

Alas the answer looks to be no

sfackler commented 6 years ago

Oh well. This seems fine then.