alexcrichton / openssl-src-rs

Source code and logic to build OpenSSL from source
Apache License 2.0
68 stars 113 forks source link

force-engine feature seems to not be including the engine #174

Closed jszwedko closed 1 year ago

jszwedko commented 1 year ago

The 111.24.0+1.1.1s release seems to include the change to add the force-engine feature (a714062):

$ git tag --contains a714062
111.23.0+1.1.1r
111.24.0+1.1.1s

However, when trying to use it, openssl-src, seems to still be providing the no-engine flag. See https://github.com/vectordotdev/vector/pull/15375, in particular the failed cross-compilation for musl.

For contrast, this fork that removes the conditional for setting no-engine does compile correctly.

I feel like I may be missing something though.

jszwedko commented 1 year ago

Hmm, actually this might be an issue with it not including the feature for build dependencies, where openssl-src also appears.

jszwedko commented 1 year ago

Yep, that was it 😅