search

alexcrichton / openssl-src-rs

Source code and logic to build OpenSSL from source
Apache License 2.0
69 stars 114 forks source link

Rust version compatibility fix #184

Open andrewwhitehead opened 1 year ago

andrewwhitehead commented 1 year ago

It seems that #180 is making use of [&OsStr]::join which was not available (broken?) until Rust 1.63: https://github.com/rust-lang/rust/pull/96881/

Related: #181

andrewwhitehead commented 1 year ago

I'm not sure why the android builds are failing, unrelated?

amousset commented 1 year ago

You can comment out the android tests, the failures are unrelated.

tsxiaofang commented 1 year ago

[&OsStr]::join which was not available (broken?) until Rust 1.63, To be compatible with versions before 1.63, join(OsStr:: new ("")) cannot be used, instead with fold(OsString::new(), |mut acc, v|{acc.push(v); acc.push(OsStr::new(" ")); acc})