search

alexcrichton / openssl-src-rs

Source code and logic to build OpenSSL from source
Apache License 2.0
68 stars 113 forks source link

Add support for openssl 3.1 #186

Closed amousset closed 1 year ago

alexcrichton commented 1 year ago

I don't know much about 3.1.0 vs 3.0.0 myself, but I would naively expect that there wouldn't be a need to maintain a release/300 branch in the same manner that release/111 has a branch. Are there breaking changes or otherwise reasons that applications would stay on 3.0.0 vs move over to 3.1.0?

amousset commented 1 year ago

Are there breaking changes or otherwise reasons that applications would stay on 3.0.0 vs move over to 3.1.0?

No breaking changes but the 3.0 branch is an LTS (maintained until 2026-09-07, while 3.1 support ends on 2025-03-14), so it may be interesting for people who want to stick to LTS versions.

But I don't have a strong opinion about this and switching from 3.0 to 3.1 might be good too.

sfackler commented 1 year ago

OpenSSL switched over to semver in 3.0, so 3.1.x is ABI compatible with 3.0.x unlike 1.0.x and 1.1.x.

alexcrichton commented 1 year ago

Is there any reason openssl-sys would want to stay pinned at 3.0.0 as opposed to automatically getting upgraded to 3.1?

If not then I'd be tempted to release a version under the 300.*.* track which bumps to 3.1.0 for OpenSSL and go with that. It's already sort of a pain maintaining two branches so I'd personally prefer to not add a third unless there's a reason to

sfackler commented 1 year ago

Yeah, we should just have a 1.1.0 and 3.x.x track.

alexcrichton commented 1 year ago

Ok cool, in that case perhaps this can bump to 300.1.0+.... as a version number?

Also if you'd like feel free to remove the Android CI builders. I don't know how to fix them off the top of my head and they're otherwise just causing noise.

amousset commented 1 year ago

If not then I'd be tempted to release a version under the 300.. track which bumps to 3.1.0 for OpenSSL and go with that. It's already sort of a pain maintaining two branches so I'd personally prefer to not add a third unless there's a reason to

I'm fine with that, updated.