search

alexcrichton / openssl-src-rs

Source code and logic to build OpenSSL from source
Apache License 2.0
68 stars 113 forks source link

fix: Sets AR for Android only if using GCC #207

Open elpiel opened 1 year ago

elpiel commented 1 year ago

Fixes an issue with Android builds with ndk version 25 and up (and possibly 24) Related issue: #188 Related PR: #196

alexcrichton commented 1 year ago

I think this might perhaps be better for the cc crate? That it's returning get_ar and get_ranlib and one of them doesn't work seems like that's best fixed upstream if possible

elpiel commented 1 year ago

I'll look into it. I haven't had the opportunity to see what cc does and if it's the right fix to go upstream.

elpiel commented 8 months ago

@alexcrichton would you consider including this fix as I don't receive any feedback or comments on the issue I created upstream in cc?

alexcrichton commented 8 months ago

Ah ok, well at least an attempt was made!

Would you be up for helping out to get Android running on CI though in lieu of upstream support? I've had to disable all the Android CI support historically due to it bitrotting but if more Android-specific support is grown here then I think it would be best to get a CI builder up-and-running to ensure that it keeps working in the future again.

elpiel commented 8 months ago

Yes, I can look into enabling the builds.