alexcrichton / openssl-src-rs

Source code and logic to build OpenSSL from source
Apache License 2.0
68 stars 113 forks source link

Bump to 3.2.0 #217

Closed amousset closed 9 months ago

amousset commented 10 months ago

Still working on reducing the size of the crate, a lof of big stuff was added.

alexcrichton commented 9 months ago

If it's too difficult to trim out the extra bits I can also email crates.io folks to try to get the size limit for this crate increased to 20M for example.

heiher commented 9 months ago

Can we exclude some unused documents to reduce the package size? Assume that the crate size limit cannot be increased anytime soon.

diff --git a/Cargo.toml b/Cargo.toml
index c32d75d..45b85de 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -21,6 +21,9 @@ exclude = [
   'openssl/tlsfuzzer/*',
   'openssl/python-ecdsa/*',
   'openssl/oqs-provider/*',
+# The current upload size limit for *.crate files is 10MB. Therefore, exclude
+# some unused documentation to meet this constraint.
+  'openssl/doc/man{3,5,7}',
 ]

 [features]
target/package/openssl-src-300.2.0+3.2.0.crate  9570580 bytes

It doesn't look like this breaks the build, I'll create a PR as soon as possible if we can do it, as this upgrade is important for LoongArch (There is a change included in 3.2.0 that fixes the build issue).

Updated:

PR: https://github.com/alexcrichton/openssl-src-rs/pull/219

alexcrichton commented 9 months ago

Want to try rebasing over #219 and see if this passes CI now?

alexcrichton commented 9 months ago

The sizing bits look good (thanks @heiher!) but it looks like there may be new runtime dependencies on Windows? Probably "just" a missing -l argument though (unsure which one myself without googling further)

alexcrichton commented 9 months ago

Oh I think that the line you'll need to modify is around here

heiher commented 9 months ago

Oh I think that the line you'll need to modify is around here

Fixed: https://github.com/alexcrichton/openssl-src-rs/pull/221

amousset commented 9 months ago

Thanks @heiher, I picked your commit (sorry for the latency, I'm not very available these days).