alexcrichton / ssh2-rs

Rust bindings for libssh2
https://docs.rs/ssh2
Apache License 2.0
485 stars 147 forks source link

please include license texts in distributed libssh2-sys crates #289

Closed decathorpe closed 1 year ago

decathorpe commented 1 year ago

Both the MIT and Apache-2.0 licenses require that redistributed sources contain a copy of the actual license text (it's one of the conditions in the license terms in both cases). However, the libssh2-sys crate as distributed via crates.io currently does not contain these license files. This is also a problem for Linux distributions (or other software distributors) which provide packages for this crate (or for projects that depend on it, where it is sometimes included in vendored sources).

It is sufficient to include symbolic links in the libssh2-sys subdirectory (i.e. LICENSE-APACHE -> ../LICENSE-APACHE and LICENSE-MIT -> ../LICENSE-MIT) for the files to be included when running cargo package / cargo publish - full copies are not necessary (unless you're running cargo publish on Windows, which does not support git symlinks correctly, as far as I know).

Thanks!