alexcrichton / ssh2-rs

Rust bindings for libssh2
https://docs.rs/ssh2
Apache License 2.0
467 stars 142 forks source link

ScpFileStat is currently unusable #290

Open ssnover opened 1 year ago

ssnover commented 1 year ago

I'm currently using the ssh2::session::Session::scp_recv api which returns a tuple of the Channel and the ScpFileStat, however the ScpFileStat is pretty much just an opaque blob as it doesn't appear to implement any conversion traits.

Would you approve an MR introducing methods to make the internal data accessible?

ssnover commented 1 year ago

Would maybe make sense to make the FileStat struct more generalized (break it out of the sftp module) and have a conversion from ScpFileStat into FileStat?

yodaldevoid commented 9 months ago

Hello and thank you for submitting this issue.

Would you approve an MR introducing methods to make the internal data accessible?

Yes, we would.