alexcrichton / ssh2-rs

Rust bindings for libssh2

https://docs.rs/ssh2

Apache License 2.0

485 stars 147 forks source link

Closed k0i closed 5 months ago

k0i commented 6 months ago

Motivation

I noticed that sftp's readdir function takes only Path . I think it is comfortable to accept &str .

So I changed the methods argument a little bit to take AsRef<Path>.

Could you please review the changes?

If this change is unacceptable, please kindly close this RR. Sorry for taking your time 🙇 !

yodaldevoid commented 5 months ago

Thank you for the patches! This is definitely a good improvement.

As long as the tests pass I'll get this merged.