search

alexcrichton / tar-rs

Tar file reading/writing for Rust
https://docs.rs/tar
Apache License 2.0
625 stars 184 forks source link

Update xattr requirement from 0.2 to 1.0 #307

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Updates the requirements on xattr to permit the latest version.

Commits
  • ff56009 Merge pull request #30 from Stebalien/chore/release
  • 036cc12 chore: release 1.0.0
  • 6b67d6b Merge pull request #29 from Stebalien/chore/cleanup
  • a60ad02 fix: macos build
  • 453a7d5 chore: 2021 edition and friends
  • cb96edf Merge pull request #27 from asomers/fbsd-12-3
  • 48791d8 Merge pull request #26 from asomers/use_libc
  • 4bcd35a Overhaul CI
  • 33d0210 Use libc's definitions where possible
  • cfc242e Merge pull request #25 from Stebalien/chore/use-unsupported
  • Additional commits viewable in compare view


You can trigger a rebase of this PR by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

eric-seppanen commented 1 year ago

It would be nice to land this change, so downstream projects aren't bringing in two versions of xattr. xattr 1.0.0 has been out for a long time now.

The CI logs are long gone, but it seems a bit strange that it hit windows build failures as this dependency is explicitly marked cfg(unix)...

alexcrichton commented 1 year ago

Help would be appreicated in fixing the CI for this if necessary!

eric-seppanen commented 1 year ago

@alexcrichton I opened an identical PR (#334) and all the CI checks pass.

Amusingly, because my branch briefly contained the same commit, github retroactively cleared the "CI / Test (windows) (pull_request)" failure on this PR, but because it's only running "pull_request" checks and not "push" checks, there is still a red X blocking this PR.

To see if it would work, I also did a dummy git commit --amend to generate a different commit id, and when I pushed that I got all passing tests (because the commit id had changed, it was no longer displaying the ancient cached "push" failure).

Summary: If you want to preserve the original dependabot commit I think it will work if you can force github to re-run CI on this PR. Otherwise, #334 is identical except for the commit metadata.

alexcrichton commented 1 year ago

Thank you!

dependabot[bot] commented 1 year ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.