search

alexcrichton / tokio-named-pipes

Windows named pipes bindings for tokio
Other
6 stars 12 forks source link

Update to latest tokio_io from deprecated tokio_core::io #2

Open NikVolf opened 7 years ago

NikVolf commented 7 years ago

Any chance this crate is going to be updated to latest changes there?

Specifically, NamedPipe should implement tokio_io::AsyncRead, tokio_io::AsyncWrite

alexcrichton commented 7 years ago

Ah I actually ended up not pursuing this crate because I ended up not needing it for my use case. In that sense it's not currently on crates.io. Would you be interested in taking it over though?

NikVolf commented 7 years ago

yeah, sure, I will try to update it on my own, will make a pr it will also require changes to mio_named_pipes, right?

alexcrichton commented 7 years ago

I don't think this'll require changes on the mio side, but I may be wrong!

c0gent commented 6 years ago

This is addressed on @NikVolf's fork (https://github.com/NikVolf/tokio-named-pipes).

@alexcrichton, May I submit a PR to add a link in readme pointing to that fork or do you want to keep development here? I can help maintain if needed.

alexcrichton commented 6 years ago

@c0gent a PR sounds great! I'm totally down for making that the new official home of this crate