alexdalitz / dnsruby

Dnsruby is a feature-complete DNS(SEC) client for Ruby, as used by many of the world's largest DNS registries and the OpenDNSSEC project
Other
194 stars 77 forks source link

rubydns no longer works in pipelining tests #155

Open alexdalitz opened 4 years ago

alexdalitz commented 4 years ago

A while ago, @nwitkowski added some test code for TCP pipelinining, based on @ioquatix rubydns library. Sadly, the interfaces changed, and the code (plus subsequent changes) no longer works in the tests. I've spent some time looking at this, and can't get the breaking changes fixed. As a result, I've removed the tests that use rubydnsm, in this commit : https://github.com/alexdalitz/dnsruby/commit/06a23f90e5cc89191de439845fbcd7078c6dfc94

If anybody is able to contribute patches which fix the broken API changes, so I can reinstate this test, I'd be very grateful.

Thanks!

ioquatix commented 4 years ago

What is not working?