search

alexdalitz / dnsruby

Dnsruby is a feature-complete DNS(SEC) client for Ruby, as used by many of the world's largest DNS registries and the OpenDNSSEC project
Other
194 stars 77 forks source link

Address Ruby 2.8 #untaint deprecation warnings #166

Closed composerinteralia closed 3 years ago

composerinteralia commented 3 years ago

Prior to this commit we were seeing errors when calling the deprecated Object#untaint method on Ruby 2.8. The method is a no-op on Ruby 2.8.

dnsruby/config.rb:325: warning: Object#untaint is deprecated and will be removed in Ruby 3.2

We probably could remove untainting for older Ruby versions as well, but it felt safer to preserve the current behavior in case someone is still relying on it.

To see this change in action, we added ruby-head to the travis matrix, but do not require those tests to pass for the build as a whole to pass.

See https://bugs.ruby-lang.org/issues/16131 for details on the deprecation.

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.02%) to 77.506% when pulling 454e0a695d9bc8a683558a0ba01d7ac33ed908ff on thoughtbot:ruby-2.7-untaint-warning into b9bd2c63d5c83cde8fcd1bcdb615200741c07b04 on alexdalitz:master.

alexdalitz commented 3 years ago

Great - thanks!