search

alexdalitz / dnsruby

Dnsruby is a feature-complete DNS(SEC) client for Ruby, as used by many of the world's largest DNS registries and the OpenDNSSEC project
Other
194 stars 77 forks source link

NoMethodError undefined method `[]' for nil:NilClass on CAA lookup #168

Closed dbackeus closed 3 years ago

dbackeus commented 3 years ago

Running:

Dnsruby::Resolver.new.query("nccgroup.com", Dnsruby::Types::CAA)

I get the error:

NoMethodError: undefined method `[]' for nil:NilClass
from /Users/davidbackeus/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/dnsruby-1.61.4/lib/dnsruby/resource/CAA.rb:47:in `from_string'
alexdalitz commented 3 years ago

Thanks for this!

It turns out that Dnsruby did not handle contactemail or contactphone.

I’ve added support to them for the master branch. Would it be possible to give it a shot, please?

Thanks!

Alex.

On 29 Oct 2020, at 12:52, David Backeus notifications@github.com wrote:

Running:

Dnsruby::Resolver.new.query("nccgroup.com", Dnsruby::Types::CAA) I get the error:

NoMethodError: undefined method []' for nil:NilClass from /Users/davidbackeus/.rbenv/versions/2.6.5/lib/ruby/gems/2.6.0/gems/dnsruby-1.61.4/lib/dnsruby/resource/CAA.rb:47:infrom_string' — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/alexdalitz/dnsruby/issues/168, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2WFWUC22MCVLPV5HFU4FTSNFQRLANCNFSM4TDWBGHA.

dbackeus commented 3 years ago

Totally works now, thanks!

Would appreciate, if you have the time, if you could push a new gem release to avoid having to use git: in the Gemfile.

alexdalitz commented 3 years ago

Sure, I can do that. However, it might take me a day or two to get a release together. I’ll leave this issue open until I’ve made a release, after which I’ll close it. So you should get a notification by that means that a new release is available.

Thanks!

On 29 Oct 2020, at 13:22, David Backeus notifications@github.com wrote:

Totally works now, thanks!

Would appreciate, if you have the time, if you could push a new gem release to avoid having to use git: in the Gemfile.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/alexdalitz/dnsruby/issues/168#issuecomment-718748546, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB2WFWWFZN544MFLDVU6T2TSNFUBJANCNFSM4TDWBGHA.

alexdalitz commented 3 years ago

Ok - Dnsruby v1.61.5 is now released :)