Clear Ruby warnings - Githubissues

alexdalitz / dnsruby

Dnsruby is a feature-complete DNS(SEC) client for Ruby, as used by many of the world's largest DNS registries and the OpenDNSSEC project

Other

194 stars 77 forks source link

Clear Ruby warnings #172

Closed casperisfine closed 3 years ago

casperisfine commented 3 years ago

DNSRuby generates tons of unused variable and other ruby warnings.

That's a problem for applications and libraries depending on it and trying to catch issues on CI/test with these warnings.

This PR clear most warnings, there's still a bunch in the test suite, but I believe it's a good start.

coveralls commented 3 years ago

Coverage decreased (-10.3%) to 66.752% when pulling d1961d4db2b283067f059df4ededff0e9e24a41b on casperisfine:fix-warnings into bb67b51bf3d85626a87ed23ebfaee30c34bbbead on alexdalitz:master.

casperisfine commented 3 years ago

Oh by the way, you don't have a CI anymore as Travis-CI.org is now shut down. Most people migrated to GitHub actions.

alexdalitz commented 3 years ago

Nice one - thanks!